dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1169925559
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ########## @@ -115,9 +115,10 @@ public int hashCode() { @Override public String toString() { return "AssignmentMemberSpec(instanceId=" + instanceId + - ", rackId=" + rackId + - ", subscribedTopicIds=" + subscribedTopicIds + - ", assignedPartitions=" + assignedPartitions + - ')'; + ", rackId=" + rackId + Review Comment: Should we revert this change now? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ########## @@ -78,7 +78,7 @@ public int hashCode() { @Override public String toString() { return "AssignmentSpec(members=" + members + - ", topics=" + topics + - ')'; + ", topics=" + topics + Review Comment: Should we revert this change now? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupAssignment.java: ########## @@ -29,7 +29,7 @@ public class GroupAssignment { private final Map<String, MemberAssignment> members; public GroupAssignment( - Map<String, MemberAssignment> members + Map<String, MemberAssignment> members Review Comment: Should we revert this change now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org