jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171913050
########## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ########## @@ -2189,7 +2196,7 @@ public void testCancelInFlightRequestAfterFatalError() throws Exception { prepareAndReceiveInitProducerId(producerId, Errors.NONE); assertTrue(transactionManager.hasProducerId()); - // cluster authorization is a fatal error for the producer + // expecting authorization error on send Review Comment: ditto here -- should we change this test to use a fatal error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org