jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1180619843
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -300,9 +301,13 @@ void runOnce() {
try {
transactionManager.maybeResolveSequences();
+ RuntimeException lastError = transactionManager.lastError();
+ if (transactionManager.hasAbortableError() &&
shouldHandleAuthorizationError(lastError)) {
+ return;
+ }
+
Review Comment:
I thought I left this comment, but seems like it didn't take -- should we
move the fatal error check above the auth check? Since for other request types,
we will go through the above path, but it really should just be a fatal error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
