[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

[via GitHub]

cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173082868


##########
metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java:
##########
@@ -105,14 +130,15 @@ private void writeFeatureLevels(ImageWriter writer, 
ImageWriterOptions options)
 
     @Override
     public int hashCode() {
-        return finalizedVersions.hashCode();
+        return Objects.hash(finalizedVersions, zkMigrationState);
     }
 
     @Override
     public boolean equals(Object o) {
         if (!(o instanceof FeaturesImage)) return false;
         FeaturesImage other = (FeaturesImage) o;
-        return finalizedVersions.equals(other.finalizedVersions);
+        return finalizedVersions.equals(other.finalizedVersions) &&

Review Comment:
   should test metadataVersion here too, oops



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org