cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1175709187
##########
core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala:
##########
@@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest {
}
@ClusterTest(clusterType = Type.KRAFT, brokers = 0, controllers = 1,
metadataVersion = MetadataVersion.IBP_3_3_IV3,
- serverProperties = Array(new ClusterConfigProperty(key =
"zookeeper.metadata.migration.enable", value = "true")))
- def testRegisterZkWithKRaftOldMetadataVersion(clusterInstance:
ClusterInstance): Unit = {
+ serverProperties = Array(new ClusterConfigProperty(key =
"zookeeper.metadata.migration.enable", value = "false")))
Review Comment:
> I added a test in QuorumControllerTest
ok
> we don't expose the fault handler outside of TestKit (which maybe we
should)
we don't have to do it now, but perhaps in the future we should add an
accessor for the fault handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
