[
https://issues.apache.org/jira/browse/KAFKA-6474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456764#comment-16456764
]
ASF GitHub Bot commented on KAFKA-6474:
---------------------------------------
h314to opened a new pull request #4939: KAFKA-6474: Rewrite tests to use new
public TopologyTestDriver [cleanup]
URL: https://github.com/apache/kafka/pull/4939
This implements the suggestions made after the previous
[PR](https://github.com/apache/kafka/pull/4832) for KAFKA-6474 was merged.
The majority of changes deals with using try-with-resources and a new method
in `StreamsTestUtils` to set the test properties and instantiate the
`TopologyTestDriver`, thus allowing the removal of the cumbersome `@Before` and
`@After` methods.
I also replaced `stringSerde` and `intSerde` variables with (almost equally
succinct) inline calls to `Serdes.String()` and `Serdes.Integer()`.
* Add method to create test properties to StreamsTestUtils
* Make TopologyTestDriver protected constructor package-private
* Add comment suggesting the use of TopologyTestDriver to KStreamTestDriver
* Cleanup:
- GlobalKTableJoinsTest
- KGroupedStreamImplTest
- KGroupedTableImplTest
- KStreamBranchTest
- KStreamFilterTest
- KStreamFlatMapTest
- KStreamFlatMapValuesTest
- KStreamForeachTest
- KStreamGlobalKTableJoinTest
- KStreamGlobalKTableLeftJoinTest
- KStreamImplTest
- KStreamKStreamJoinTest
- KStreamKStreamLeftJoinTest
- KStreamGlobalKTableLeftJoinTest
- KStreamKTableJoinTest
- KStreamKTableLeftJoinTest
- KStreamMapTest
- KStreamMapValuesTest
- KStreamPeekTest
- StreamsBuilderTest
- KStreamSelectKeyTest
- KStreamTransformTest
- KStreamTransformValuesTest
- KStreamWindowAggregateTest
- KTableForeachTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rewrite test to use new public TopologyTestDriver
> -------------------------------------------------
>
> Key: KAFKA-6474
> URL: https://issues.apache.org/jira/browse/KAFKA-6474
> Project: Kafka
> Issue Type: Improvement
> Components: streams, unit tests
> Affects Versions: 1.1.0
> Reporter: Matthias J. Sax
> Assignee: Filipe Agapito
> Priority: Major
> Labels: beginner, newbie
>
> With KIP-247 we added public TopologyTestDriver. We should rewrite out own
> test to use this new test driver and remove the two classes
> ProcessorTopoogyTestDriver and KStreamTestDriver.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
