[ 
https://issues.apache.org/jira/browse/KAFKA-6474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468686#comment-16468686
 ] 

ASF GitHub Bot commented on KAFKA-6474:
---------------------------------------

h314to opened a new pull request #4986: KAFKA-6474: Rewrite tests to use new 
public TopologyTestDriver [part 2]
URL: https://github.com/apache/kafka/pull/4986
 
 
   This PR is a further step towards the complete replacement of 
`KStreamTestDriver` with `TopologyTestDriver`. Currently there's only a few 
tests in  `KTableAggregateTest` which don't work with `TopologyTestDriver` . 
Everything else has now been migrated to the new driver.
   
   * Refactor:
     - TimeWindowedKStreamImplTest
     - SessionWindowedKStreamImplTest
     - KTableMapKeysTest
     - KTableFilterTest
     - KTableKTableInnerJoinTest
     - KTableSourceTest
     - KTableMapValuesTest
     - KTableKTableOuterJoinTest
     - KTableKTableLeftJoinTest
     - KStreamWindowReduceTest
     - KTableImplTest.
     - KTableAggregateTest (partial)
   
   * Rename TopologyTestDriverWrapper to TopologyTestDriverAccessor.
   * Add task, processorTopology, and globalTopology access to 
TopologyTestDriverAccessor
   * Add condition to prevent NPE in ProcessorContextImpl
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rewrite test to use new public TopologyTestDriver
> -------------------------------------------------
>
>                 Key: KAFKA-6474
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6474
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>    Affects Versions: 1.1.0
>            Reporter: Matthias J. Sax
>            Assignee: Filipe Agapito
>            Priority: Major
>              Labels: beginner, newbie
>
> With KIP-247 we added public TopologyTestDriver. We should rewrite out own 
> test to use this new test driver and remove the two classes 
> ProcessorTopoogyTestDriver and KStreamTestDriver.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to