andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1212980561
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -77,39 +77,75 @@ public void testChangeRecordIsNoOp() {
);
}
- private final static PartitionRegistration FOO = new PartitionRegistration(
- new int[] {2, 1, 3}, new int[] {2, 1, 3}, Replicas.NONE, Replicas.NONE,
- 1, LeaderRecoveryState.RECOVERED, 100, 200);
+ private static final PartitionRegistration FOO;
+
+ static {
+ try {
+ FOO = new PartitionRegistration.Builder().
+ setReplicas(new int[] {2, 1, 3}).
+ setIsr(new int[] {2, 1, 3}).
+ setRemovingReplicas(Replicas.NONE).
+ setAddingReplicas(Replicas.NONE).
Review Comment:
Done here and all the other places.
##########
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##########
@@ -33,6 +33,92 @@
public class PartitionRegistration {
+
+ /**
+ * A builder class which creates a PartitionRegistration.
+ */
+ static public class Builder {
+ private int[] replicas;
+ private int[] isr;
+ private int[] removingReplicas;
+ private int[] addingReplicas;
+ private Integer leader;
+ private LeaderRecoveryState leaderRecoveryState;
+ private Integer leaderEpoch;
+ private Integer partitionEpoch;
+
+ public Builder setReplicas(int[] replicas) {
+ this.replicas = replicas;
+ return this;
+ }
+
+ public Builder setIsr(int[] isr) {
+ this.isr = isr;
+ return this;
+ }
+
+ public Builder setRemovingReplicas(int[] removingReplicas) {
+ this.removingReplicas = removingReplicas;
+ return this;
+ }
+
+ public Builder setAddingReplicas(int[] addingReplicas) {
+ this.addingReplicas = addingReplicas;
+ return this;
+ }
+
+ public Builder setLeader(Integer leader) {
+ this.leader = leader;
+ return this;
+ }
+
+ public Builder setLeaderRecoveryState(LeaderRecoveryState
leaderRecoveryState) {
+ this.leaderRecoveryState = leaderRecoveryState;
+ return this;
+ }
+
+ public Builder setLeaderEpoch(Integer leaderEpoch) {
+ this.leaderEpoch = leaderEpoch;
+ return this;
+ }
+
+ public Builder setPartitionEpoch(Integer partitionEpoch) {
+ this.partitionEpoch = partitionEpoch;
+ return this;
+ }
+
+ public PartitionRegistration build() throws Exception {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
