andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1218539167
##########
core/src/test/scala/unit/kafka/zk/migration/ZkMigrationClientTest.scala:
##########
@@ -371,17 +371,17 @@ class ZkMigrationClientTest extends
ZkMigrationTestHarness {
val topicId = Uuid.randomUuid()
val partitions = Map(
- 0 -> new PartitionRegistration(Array(0, 1, 2), Array(0, 1, 2), Array(),
Array(), 0, LeaderRecoveryState.RECOVERED, 0, -1),
- 1 -> new PartitionRegistration(Array(1, 2, 3), Array(1, 2, 3), Array(),
Array(), 1, LeaderRecoveryState.RECOVERED, 0, -1)
+ 0 -> new PartitionRegistration.Builder().setReplicas(Array(0, 1,
2)).setIsr(Array(0, 1,
2)).setLeader(0).setLeaderRecoveryState(LeaderRecoveryState.RECOVERED).setLeaderEpoch(0).setPartitionEpoch(1).build(),
Review Comment:
It apparently doesnt affect the test. But I agree it should be -1 for
consistency. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
