jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1213757295
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -33,7 +35,8 @@ object AddPartitionsToTxnManager {
class TransactionDataAndCallbacks(val transactionData:
AddPartitionsToTxnTransactionCollection,
- val callbacks: mutable.Map[String,
AddPartitionsToTxnManager.AppendCallback])
+ val callbacks: mutable.Map[String,
AddPartitionsToTxnManager.AppendCallback],
+ val earliestAdditionMs: Long)
Review Comment:
The current approach I take is that we find the max verification time for
the transaction data. I can either change this or clarify in the metric.
I wanted to take a per transaction level approach, but it gets a little bit
harder to store the per transaction data since transaction data is an already
defined collection. I could instead create a (parallel) map for each
transaction if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
