jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1228731391
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -85,12 +93,14 @@ class AddPartitionsToTxnManager(config: KafkaConfig,
client: NetworkClient, time
topicPartitionsToError.put(new TopicPartition(topic.name, partition),
error)
}
}
+ verificationFailureRate.mark(topicPartitionsToError.size)
topicPartitionsToError.toMap
}
private class AddPartitionsToTxnHandler(node: Node,
transactionDataAndCallbacks: TransactionDataAndCallbacks) extends
RequestCompletionHandler {
override def onComplete(response: ClientResponse): Unit = {
// Note: Synchronization is not needed on inflightNodes since it is
always accessed from this thread.
+ verificationTimeMs.update(time.milliseconds() -
transactionDataAndCallbacks.earliestAdditionMs)
Review Comment:
I've decided to fix this to have an update per produce request that comes
into the manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
