vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1229405593
##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##########
@@ -302,7 +326,12 @@ public Future<Void> set(Map<ByteBuffer, ByteBuffer>
values, Callback<Void> callb
}
}
try (LoggingContext context = loggingContext()) {
- callback.onCompletion(primaryWriteError, ignored);
+ Throwable secondaryWriteError =
secondaryStoreTombstoneWriteError.get();
+ if (secondaryStore != null && containsTombstones &&
secondaryWriteError != null) {
Review Comment:
That's true and I have tweaked the logic to wait for secondary store write
in case of tombstone records before proceeding with primary store writes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
