lucasbru commented on code in PR #13876:
URL: https://github.com/apache/kafka/pull/13876#discussion_r1236873661
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -1013,16 +1013,8 @@ private void maybeFailWithError() {
if (!hasError()) {
return;
}
- // for ProducerFencedException, do not wrap it as a KafkaException
Review Comment:
That's as much as I got from the comment, but I am not sure if it makes
sense. Yes, producers are generally not fenced because of a specific operation,
but because something happened on the server side, but it's still "correct" to
include a call trace to the operation where the broker first returned a fencing
error. At least, it doesn't seem worth complicating the exception handling with
these inconsistencies to hide the call trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
