jolshan commented on PR #13876: URL: https://github.com/apache/kafka/pull/13876#issuecomment-1607891946
> - Keep things somewhat inconsistent > - Do not wrap fatal exceptions and keep the exceptions as-is > - Do wrap fatal exceptions and let the users deal with it > - Always rethrow with the correct exception type, so we do wrap the exception (giving us the right stack traces), but we don't use KafkaException but call a new method rethrow on KafkaException that rethrows the exception. However, that would certainly require a new KIP. These options I'm assuming are just for the ProducerFencedException and InvalidProducerEpochException? Or is this referring to the entire PR? I think maybe those two exceptions are the biggest concerns for the reasons you mention above. If it is the case, is the main reason for wrapping consistency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
