jolshan commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1247245146
##########
core/src/main/scala/kafka/network/RequestChannel.scala:
##########
@@ -507,9 +507,14 @@ class RequestChannel(val queueSize: Int,
def sendShutdownRequest(): Unit = requestQueue.put(ShutdownRequest)
def sendCallbackRequest(request: CallbackRequest): Unit = {
- callbackQueue.put(request)
- if (!requestQueue.offer(RequestChannel.WakeupRequest))
- trace("Wakeup request could not be added to queue. This means queue is
full, so we will still process callback.")
+ try {
+ callbackQueue.put(request)
+ if (!requestQueue.offer(RequestChannel.WakeupRequest))
+ trace("Wakeup request could not be added to queue. This means queue is
full, so we will still process callback.")
+ } catch {
+ case e: Throwable =>
+ warn("There was an exception when attempting to send the callback
request", e)
Review Comment:
Hmmm -- I guess we would not send a response. Do we send a response normally
though if we shutdown during handling a request? Or do we just rely on it to
time out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
