jolshan commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1256502612
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition,
// Returns a verification guard object if we need to verify. This starts or
continues the verification process. Otherwise return null.
def maybeStartTransactionVerification(producerId: Long): Object = {
- leaderLogIfLocal match {
+ log match {
Review Comment:
I am a bit concerned with changing the flow here though. At the very least I
suspect that some produce requests will be slower since we will have to retry
in some cases when we elected. Maybe this isn't a big concern, but I still
think it is a larger change.
As for the log not existing -- would we elect a log as leader and send a
request to it before the log exists?
@hachikuji what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
