jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1253525703
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##########
@@ -37,18 +38,51 @@ public class CoordinatorResult<T, U> {
*/
private final T response;
+ /**
+ * The future to complete once the records are committed.
+ */
+ private final CompletableFuture<T> appendFuture;
Review Comment:
this is only used when records are generated (and need to be appended to the
log) so i think append future makes more sense.
`completionFuture` will be confusing alongside coordinator event's `future`
field. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
