jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1256069184
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -150,19 +215,39 @@ GroupMetadataManager build() {
throw new IllegalStateException("Assignors must be set before
building.");
}
+ if (topicPartition == null) {
+ throw new IllegalStateException("TopicPartition must be set
before building.");
+ }
+
+ if (timer == null) {
+ throw new IllegalStateException("Timer must be set before
building.");
+ }
+
return new GroupMetadataManager(
snapshotRegistry,
logContext,
- time,
assignors,
metadataImage,
+ consumerGroupMetadataRefreshIntervalMs,
+ topicPartition,
consumerGroupMaxSize,
consumerGroupHeartbeatIntervalMs,
- consumerGroupMetadataRefreshIntervalMs
Review Comment:
reverted the ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
