philipnee commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1265845671
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ########## @@ -522,7 +525,35 @@ public void subscribe(Collection<String> topics, ConsumerRebalanceListener callb @Override public void assign(Collection<TopicPartition> partitions) { - throw new KafkaException("method not implemented"); + if (partitions == null) { + throw new IllegalArgumentException("Topic partitions collection to assign to cannot be null"); + } + + if (partitions.isEmpty()) { + this.unsubscribe(); + return; + } + + for (TopicPartition tp : partitions) { + String topic = (tp != null) ? tp.topic() : null; + if (Utils.isBlank(topic)) + throw new IllegalArgumentException("Topic partitions to assign to cannot have null or empty topic"); + } + // TODO: implement fetcher + // fetcher.clearBufferedDataForUnassignedPartitions(partitions); + + // make sure the offsets of topic partitions the consumer is unsubscribing from + // are committed since there will be no following rebalance + commit(subscriptions.allConsumed()); Review Comment: Thanks, @lianetm - As autocommit is handled by the commitRequestManager, the application thread is only responsible for sending an assignment change event to the background thread. This is tested in the `PrototypeAsyncConsumer.testAssign()`. The autocommit was also tested in the request manager. I would add a test to the DefaultBackgroundThreadTest to test if the AssignmentChange event triggers the autocommit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org