philipnee commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1265943974
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ########## @@ -106,4 +114,17 @@ private boolean process(final OffsetFetchApplicationEvent event) { manager.addOffsetFetchRequest(event.partitions); return true; } + + private boolean process(final NewTopicsMetadataUpdateRequestEvent event) { + metadata.requestUpdateForNewTopics(); + return true; + } + + private boolean process(final AssignmentChangeApplicationEvent event) { + Optional<RequestManager> commitRequestManger = registry.get(RequestManager.Type.COMMIT); + CommitRequestManager manager = (CommitRequestManager) commitRequestManger.get(); Review Comment: I think an isPresent check is missing here. Updated. To your question: when groupId is null, we don't build the coordinator request manager and thus the commit request manager, so isPresent check is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org