showuon commented on code in PR #14028:
URL: https://github.com/apache/kafka/pull/14028#discussion_r1266313198
##########
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java:
##########
@@ -117,6 +120,15 @@ public Integer value() {
return (int) zkMigrationState();
}
}));
+
+ if (zkMigrationEnabled) {
Review Comment:
Since we have passed in `zkMigrationEnabled` parameter, should we also put
the above `ZK_MIGRATION_STATE` metric under this if block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
