mumrah commented on code in PR #14028:
URL: https://github.com/apache/kafka/pull/14028#discussion_r1266763142
##########
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java:
##########
@@ -117,6 +120,15 @@ public Integer value() {
return (int) zkMigrationState();
}
}));
+
+ if (zkMigrationEnabled) {
Review Comment:
We actually want this one reported in all cases. For de-novo KRaft clusters,
this will be 0 (never migrated) which will let us distinguish from clusters
which have a completed a migration (3 for post-migration). We can remove this
metric in 4.0 once ZK and all the migration code is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
