vamossagar12 commented on PR #14000: URL: https://github.com/apache/kafka/pull/14000#issuecomment-1642481356
Thanks @gharris1727 . hmm the meaning of the variable and it's usage in the comment is slightly off in this case. `revokedInPrevious` being true doesn't just signify successive revoking rebalances (which is what the original comment reflects) but also signifies that *just* the previous round had one. I just realised that my updated comment isn't accurate as well and ideally both should be included. Something along the lines of ``` There are no lost assignments and there have been no revoking rebalances in the previous round(s) ``` would be more accurate imo. WDYT? Also, there is a bug where in due to empty lost assignments and a follow up rebalance post connector deletions can lead to these lines getting printed: https://github.com/apache/kafka/pull/14000/files#diff-e24067b121eb960feebfa099bd9c30382e330eaf5db39302a9d7a50e29b3acb4L459-R462 Ideally nothing should happen if lost assignments are empty. I haven't had the chance to take a look at fixing it though. Will file a ticket later when I have some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
