vamossagar12 commented on code in PR #14000:
URL: https://github.com/apache/kafka/pull/14000#discussion_r1279415811
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##########
@@ -161,30 +161,38 @@ public void
testAssignmentsWhenWorkersJoinAfterRevocations() {
time.sleep(assignor.delay);
addNewEmptyWorkers("worker4");
performStandardRebalance();
+ assertEquals(0, assignor.delay); // No revocations in this round.
assertWorkers("worker1", "worker2", "worker3", "worker4");
assertConnectorAllocations(0, 0, 1, 1);
assertTaskAllocations(0, 3, 3, 3);
// Fifth assignment and a fifth worker joining after a revoking
rebalance.
- // We shouldn't revoke and set a delay > initial interval
+ // We shouldn't revoke and set a delay equal to initial interval
addNewEmptyWorkers("worker5");
performStandardRebalance();
- assertTrue(assignor.delay > 40);
+ assertEquals(40, assignor.delay); // First successive revoking
rebalance.
assertWorkers("worker1", "worker2", "worker3", "worker4", "worker5");
assertConnectorAllocations(0, 0, 1, 1, 1);
assertTaskAllocations(1, 2, 3, 3, 3);
- // Sixth assignment with sixth worker joining after the expiry.
- // Should revoke
- time.sleep(assignor.delay);
Review Comment:
I removed this to prove that the changes still work correctly and the delay
gets extended further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
