dajac commented on PR #14046:
URL: https://github.com/apache/kafka/pull/14046#issuecomment-1643522968

   @jolshan I was actually thinking about the `AuthorizerIntegrationTest` 
failures overnight and I found an issue with the `latestVersionUnstable` flag. 
Let me try to explain.
   
   The `latestVersionUnstable` is used on the broker side to ensure that an 
unreleased/unstable version is not exposed by the broker. That's fine. However, 
it does not guarantee that a client having an unreleased/unstable version is 
not going to use it.
   
   Let's take this change as an example. The version 9 will be shipped in the 
next release even if we don't want to use it because the schema is there. So 
the client knows about it and may use it if the broker eventually supports the 
version. The issue is that the release version my be different from the one 
shipped so the client would get an error.
   
   I have updated the `AbstractRequest.Builder` to be defensive and only 
consider stable versions. If the user wants to construct a request for an 
unstable version, it has to specify it explicitly. This guarantee that even if 
an unstable version is shipped, it is never used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to