jolshan commented on code in PR #14067:
URL: https://github.com/apache/kafka/pull/14067#discussion_r1271173194
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -408,6 +408,31 @@ public MetadataImage image() {
return metadataImage;
}
+ /**
+ *
+ * @param groupId
+ * @param createIfNotExists
+ * @return
+ * @throws GroupIdNotFoundException
+ */
+ public Group getOrMaybeCreateSimpleGroup(
Review Comment:
This naming is a bit confusing since I thought we only get the simple group.
(Not any group)
We should probably will in line 415 and that may help clear it up a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
