dajac commented on code in PR #14067:
URL: https://github.com/apache/kafka/pull/14067#discussion_r1272025183
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -471,9 +472,48 @@ public CompletableFuture<OffsetCommitResponseData>
commitOffsets(
return
FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception());
}
- return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
- "This API is not implemented yet."
- ));
+ if (request.groupId() == null) {
+ return
CompletableFuture.completedFuture(OffsetCommitRequest.getErrorResponse(
+ request,
+ Errors.INVALID_GROUP_ID
+ ));
+ }
+
+ return runtime.scheduleWriteOperation(
+ "commit-offset",
+ topicPartitionFor(request.groupId()),
+ coordinator -> coordinator.commitOffset(context, request)
+ ).exceptionally(exception -> {
Review Comment:
Correct. Note that `NOT_ENOUGH_REPLICAS_AFTER_APPEND` is not in the new code
because this cannot happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
