vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1650338567

   Regarding 
   
   > Can we skip writes for tombstone records to the secondary store in our 
second write (the one that takes place after we've written to the primary 
store)? It's a bit of an optimization, and a bit of a readability improvement: 
it explicitly calls out the three-step process that we want to engage in when 
offsets contain tombstones where we first write tombstones to the secondary 
store, then we write everything to the primary store, and then finally we write 
non-tombstones to the secondary store.
   
   Currently a batch of records consisting of tombstone offsets proceeds in an 
all or nothing manner. I guess the main goal we are trying to achieve with this 
suggestion is that the tombstone offsets remain consistent across the 2 stores 
and even if the non-tombstone records fail to be written in the secondary store 
it is ok. Yeah I will make that change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to