vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1651603163
> Thanks Sagar! I had a feeling the implementation for this would be a little tricky, appreciate you taking a stab at it. > > I've left some inline suggestions and have some higher-level thoughts/suggestions as well: > > 1. Can we update the description to remove the parts that were copied from the Jira ticket? It's fine to just link to the ticket, and that also makes it easier to distinguish between the information already contained there, and new information contained only in this PR. > 2. Can we skip writes for tombstone records to the secondary store in our second write (the one that takes place after we've written to the primary store)? It's a bit of an optimization, and a bit of a readability improvement: it explicitly calls out the three-step process that we want to engage in when offsets contain tombstones where we first write tombstones to the secondary store, then we write everything to the primary store, and then finally we write non-tombstones to the secondary store. I have handled point #2 which now makes it a 3-step process as described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
