dajac commented on code in PR #14099:
URL: https://github.com/apache/kafka/pull/14099#discussion_r1275243699
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##########
@@ -131,13 +131,24 @@ public static Record newGroupSubscriptionMetadataRecord(
Map<String, TopicMetadata> newSubscriptionMetadata
) {
ConsumerGroupPartitionMetadataValue value = new
ConsumerGroupPartitionMetadataValue();
- newSubscriptionMetadata.forEach((topicName, topicMetadata) ->
+ newSubscriptionMetadata.forEach((topicName, topicMetadata) -> {
+ List<ConsumerGroupPartitionMetadataValue.PartitionMetadata>
partitionMetadata = new ArrayList<>();
+ if (!topicMetadata.partitionRacks().isEmpty()) {
+ topicMetadata.partitionRacks().forEach((partition, racks) -> {
+ partitionMetadata.add(new
ConsumerGroupPartitionMetadataValue.PartitionMetadata()
+ .setPartition(partition)
+ .setRacks(new ArrayList<>(racks))
+ );
+ });
+ }
+ // If partition rack information is empty, store an empty list in
the record.
value.topics().add(new
ConsumerGroupPartitionMetadataValue.TopicMetadata()
.setTopicId(topicMetadata.id())
.setTopicName(topicMetadata.name())
.setNumPartitions(topicMetadata.numPartitions())
- )
- );
+ .setPartitionMetadata(partitionMetadata.isEmpty() ?
Collections.emptyList() : partitionMetadata)
Review Comment:
Using `Collections.emptyList` makes sense when you can avoid allocating an
empty `ArrayList`. In this case, the array is already allocated so we could
just use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
