rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275362470
########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ########## @@ -222,8 +231,25 @@ public void testCreateAssignmentMemberSpec() { Map<String, TopicMetadata> subscriptionMetadata = new HashMap<String, TopicMetadata>() { { - put("foo", new TopicMetadata(fooTopicId, "foo", 5)); - put("bar", new TopicMetadata(barTopicId, "bar", 5)); + put("foo", new TopicMetadata(fooTopicId, "foo", 5, + mkMap( + mkEntry(0, Collections.emptySet()), + mkEntry(1, Collections.emptySet()), + mkEntry(2, Collections.emptySet()), + mkEntry(3, Collections.emptySet()), + mkEntry(4, Collections.emptySet()) + ) Review Comment: I kept it just in case we wanted to add the rack information, also wanted some tests with a map with information rather than just an empty map but since these tests aren't related to the rack info I'll just pass the empty map for most and add a test that checks for the rack info -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org