[GitHub] [kafka] C0urante commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

[via GitHub]

C0urante commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1283458256


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##########
@@ -197,15 +202,23 @@ public static boolean isClassFile(Path path) {
         return path.toString().toLowerCase(Locale.ROOT).endsWith(".class");
     }
 
-    public static Set<Path> pluginLocations(String pluginPath) {
+    public static Set<Path> pluginLocations(String pluginPath, boolean 
failFast) {
         if (pluginPath == null) {
             return Collections.emptySet();
         }
         String[] pluginPathElements = 
COMMA_WITH_WHITESPACE.split(pluginPath.trim(), -1);
         Set<Path> pluginLocations = new LinkedHashSet<>();
         for (String path : pluginPathElements) {
             try {
-                Path pluginPathElement = Paths.get(path).toAbsolutePath();
+                Path specifiedPath = Paths.get(path);
+                Path pluginPathElement = specifiedPath.toAbsolutePath();
+                if (!specifiedPath.isAbsolute()) {
+                    log.warn("Plugin path element '{}' is relative, evaluating 
to {}.",
+                            specifiedPath, pluginPathElement);
+                }

Review Comment:
   The condition here should be `pluginPath.isEmpty()`, not 
`!pluginPath.isEmpty()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org