gharris1727 commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1664357525
> Hmm... seems like we're still failing to detect missing manifests for plugins that implement multiple interfaces. I added a Converter manifest for the JSON converter (but not a HeaderConverter manifest), then ran the tool: Thanks, fixed this and added a manifest to the NonMigratedMultiPlugin to reproduce it. > However, I'm worried if we're reporting false (or at least, misleading) positives in cases where all plugins in a given location both cannot be loaded and do not have a manifest. If that occurs, do we report that location as compatible? And if so, isn't that likely to confuse users? Compatible here is shorthand to mean that under various `plugin.discovery` settings, the plugin will behave the same. A plugin which is not loadable and does not have a manifest will not appear in the listing, and is vacuously considered compatible. This is because the output of the PluginScanners cannot distinguish between a class which does not exist and which does exist but has some error during loading. I'm using this definition of compatible because the sync-manifests command can "make plugins compatible" by adding or removing manifests. If erroneous plugins were not considered compatible, then the sync-manifests command could not "make plugins compatible" because that would involve solving the errors, which is not in scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
