kamalcph commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1284973824
########## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ########## @@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig { "less than or equal to `log.retention.bytes` value."; public static final Long DEFAULT_LOG_LOCAL_RETENTION_BYTES = -2L; + public static final String REMOTE_LOG_METADATA_PREFIX = "remote.log.metadata"; Review Comment: Should we append the `PROP` (or) `CONFIG` suffix to it? ########## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ########## @@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig { "less than or equal to `log.retention.bytes` value."; public static final Long DEFAULT_LOG_LOCAL_RETENTION_BYTES = -2L; + public static final String REMOTE_LOG_METADATA_PREFIX = "remote.log.metadata"; Review Comment: Should we have append the `_PROP` (or) `_CONFIG` suffix to it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org