divijvaidya commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1288158470
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -913,6 +969,12 @@ private RemoteLogManagerConfig createRLMConfig(Properties
props) {
props.put(RemoteLogManagerConfig.REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP, true);
props.put(RemoteLogManagerConfig.REMOTE_STORAGE_MANAGER_CLASS_NAME_PROP,
NoOpRemoteStorageManager.class.getName());
props.put(RemoteLogManagerConfig.REMOTE_LOG_METADATA_MANAGER_CLASS_NAME_PROP,
NoOpRemoteLogMetadataManager.class.getName());
+ props.put(REMOTE_LOG_METADATA_TOPIC_PARTITIONS_PROP,
remoteLogMetadataTopicPartitionsNum);
+ props.put(remoteLogMetadataTestProp, remoteLogMetadataTestVal);
+ props.put(remoteLogMetadataCommonClientTestProp,
remoteLogMetadataCommonClientTestVal);
+ props.put(remoteLogMetadataConsumerTestProp,
remoteLogMetadataConsumerTestVal);
+ props.put(remoteLogMetadataProducerTestProp,
remoteLogMetadataProducerTestVal);
Review Comment:
Perhaps, create a `TestUtils.remoteLogTopicBasedRlmmConfig()` similar to
`TestUtils.producerConfig` or `TestUtils.createBrokerConfigs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
