kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286059074
##########
core/src/main/scala/kafka/server/KafkaBroker.scala:
##########
@@ -19,6 +19,7 @@ package kafka.server
import com.yammer.metrics.core.MetricName
import kafka.log.LogManager
+import kafka.log.remote.RemoteLogManager
Review Comment:
This import is being used in L83.
Removed the unused import "scala.collection.Seq" from this class, but it
throwing below error, so reverted it back:
```
❯ ./gradlew :storage:compileTestJava -PscalaVersion=2.13
> Configure project :
Starting build with version 3.6.0-SNAPSHOT (commit id d109f88d) using Gradle
8.2.1, Java 11 and Scala 2.13.11
Build properties: maxParallelForks=12, maxScalacThreads=8, maxTestRetries=0
> Task :core:compileScala
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:910:69:
type mismatch;
found :
scala.collection.mutable.Buffer[org.apache.kafka.common.metrics.MetricsReporter]
required: Seq[AnyRef]
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:915:61:
type mismatch;
found :
scala.collection.mutable.Buffer[org.apache.kafka.common.metrics.MetricsReporter]
required: Seq[AnyRef]
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/KafkaServer.scala:267:77:
type mismatch;
found : Seq[Object] (in scala.collection)
required: Seq[AnyRef] (in scala.collection.immutable)
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/KafkaServer.scala:117:15:
private val kafkaMetricsReporters in class KafkaServer is never used
four errors found
```
##########
core/src/main/scala/kafka/server/KafkaBroker.scala:
##########
@@ -19,6 +19,7 @@ package kafka.server
import com.yammer.metrics.core.MetricName
import kafka.log.LogManager
+import kafka.log.remote.RemoteLogManager
Review Comment:
This import is being used in L83.
Removed the unused import "scala.collection.Seq" from this class, but it
throwing below error, so reverted it back:
```
❯ ./gradlew :storage:compileTestJava -PscalaVersion=2.13
> Configure project :
Starting build with version 3.6.0-SNAPSHOT (commit id d109f88d) using Gradle
8.2.1, Java 11 and Scala 2.13.11
Build properties: maxParallelForks=12, maxScalacThreads=8, maxTestRetries=0
> Task :core:compileScala
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:910:69:
type mismatch;
found :
scala.collection.mutable.Buffer[org.apache.kafka.common.metrics.MetricsReporter]
required: Seq[AnyRef]
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:915:61:
type mismatch;
found :
scala.collection.mutable.Buffer[org.apache.kafka.common.metrics.MetricsReporter]
required: Seq[AnyRef]
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/KafkaServer.scala:267:77:
type mismatch;
found : Seq[Object] (in scala.collection)
required: Seq[AnyRef] (in scala.collection.immutable)
[Error]
/Users/kchandraprakash/projects/kafka/core/src/main/scala/kafka/server/KafkaServer.scala:117:15:
private val kafkaMetricsReporters in class KafkaServer is never used
four errors found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
