clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1286895377
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
Review Comment:
In essence, we cannot block the configuration if the property is read-only.
What we can do is terminate the startup of the broker should we detect that
this property is set to false and there are topics with a
`remote.storage.enable` property set (regardless of whether it is true or
false).
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
Review Comment:
In essence, we cannot block the configuration change if the property is
read-only. What we can do is terminate the startup of the broker should we
detect that this property is set to false and there are topics with a
`remote.storage.enable` property set (regardless of whether it is true or
false).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
