clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1287005592
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
Review Comment:
> Ah, I realised that this method is also called during startup and the
`kafkaConfig.remoteLogManagerConfig` is not stored in Zk since it is not a
dynamic config.
>
> I was hoping we could do something like
>
>
https://github.com/apache/kafka/blob/8dec3e66163420ee0c2c259eef6e0c0f3185ca17/core/src/main/scala/kafka/server/KafkaConfig.scala#L2212
> . This is because we currently don't perform config validation in
ConfigHandler and I was hoping there is a better place to do it.
>
> Let me think about it and will let you know if I have a better suggestion.
I saw that as well, but the problem is that the topic configuration is a
separate entity to the KafkaConfig. But sure, let me know if something else has
your preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
