mjsax commented on code in PR #14149:
URL: https://github.com/apache/kafka/pull/14149#discussion_r1289369350
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -1063,9 +1071,13 @@ private Map<TaskId, Set<TopicPartition>>
buildStandbyTaskMap(final String consum
}
for (final TaskId task : revokedTasks) {
- if (allStatefulTasks.contains(task)) {
Review Comment:
> Another noob question, how does standby work with in-memory state store?
Is it also reading from changelog topic?
Yes.
> If so, what's the problem of losing state for in-memory state store as it
can be restored from changelog topic?
The problem is, that we would have to restore from the changelog, and we
want to avoid this restore. In the end, there is a task that as the full state
in-memory, and we would close the task, drop the state, and re-create the same
task and restore. We basically want to avoid the "close and re-create" part.
(For RocksDB it's not an issue to close a task, because when we re-open it, the
state is still on disk and restoring from the changelog won't be necessary).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
