mjsax commented on code in PR #14149:
URL: https://github.com/apache/kafka/pull/14149#discussion_r1289372985
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -1063,9 +1071,13 @@ private Map<TaskId, Set<TopicPartition>>
buildStandbyTaskMap(final String consum
}
for (final TaskId task : revokedTasks) {
- if (allStatefulTasks.contains(task)) {
Review Comment:
> Not sure I fully understand the change here either. Would appreciate some
more explanations --- specifically, could you give a simple example in the PR
description?
Also not 100% sure -- I left another comment -- however I believe, we
current assign standbies out of think air, even into client that should not
have them, but we only want these standbies for certain client that had such a
task in the previous assignment. But details are also a little bit unclear to
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
