mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1289573138
##########
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##########
@@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest {
}
}
- @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
- @ValueSource(strings = Array("zk", "kraft"))
- def testSendWithInvalidCreateTime(quorum: String): Unit = {
+ @ParameterizedTest
+ @MethodSource(Array("timestampConfigProvider"))
+ def testSendWithInvalidBeforeAndAfterTimestamp(messageTimeStampConfig:
String, recordTimestamp: Long): Unit = {
Review Comment:
added more tests cases for valid scenarios of 1) when topic config threshold
is the same us the record timestamp 2) when record timestamp is within range of
threshold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
