mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365
########## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ########## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest { } } - @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName) Review Comment: Thank you for clarifying that. I have added the `quorum` param and verified that the test name is actually updated during runtime as you described. Here is what I have captured from the test run out put ``` Gradle Test Run :core:test > Gradle Test Executor 3 > PlaintextProducerSendTest > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long) > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long).quorum=zk PASSED Gradle Test Run :core:test > Gradle Test Executor 3 > PlaintextProducerSendTest > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long) > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long).quorum=zk PASSED Gradle Test Run :core:test > Gradle Test Executor 3 > PlaintextProducerSendTest > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long) > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long).quorum=zk PASSED Gradle Test Run :core:test > Gradle Test Executor 3 > PlaintextProducerSendTest > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long) > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long).quorum=kraft PASSED Gradle Test Run :core:test > Gradle Test Executor 3 > PlaintextProducerSendTest > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long) > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long).quorum=kraft PASSED Gradle Test Run :core:test > Gradle Test Executor 3 > PlaintextProducerSendTest > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long) > testSendWithInvalidBeforeAndAfterTimestamp(String, String, long).quorum=kraft PASSED ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org