clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1297412799
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
Review Comment:
~~I have been looking at this a bit more and I don't think the current
codebase invokes the validation path on pulling dynamic configurations. In
other words, I believe there is client to broker validation, broker to metadata
store validation, but once the data makes it in the metadata store we no longer
carry out validation when we read it back from there. Unless I am wrong this
means that we cannot unite these two approaches without big changes
(system-wide needs to happen when we pull the dynamic configuration while the
topic-specific needs to happen at broker to metadata store boundary). Am I
wrong?~~
I believe I figured out how to combine them and will have a new commit
tomorrow morning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
