divijvaidya commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1294983667
##########
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##########
@@ -154,6 +155,96 @@ class KafkaServerTest extends QuorumTestHarness {
server.shutdown()
}
+ @Test
+ def testClusterWideDisablementOfTieredStorageWithEnabledTieredTopic(): Unit
= {
+ val tsEnabledProps = TestUtils.createBrokerConfigs(1, zkConnect).head
Review Comment:
please add tests for kraft as well and for each case when broker is a
controller, when broker is a KraftServer and when broker is a ZkServer. Asking
because some of the initialization code path varies amongst them and we can't
be sure that the config validation is always called correctly in the future as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
