dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302270931
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -498,9 +526,35 @@ public
CompletableFuture<List<OffsetFetchResponseData.OffsetFetchResponseTopics>
return
FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception());
}
- return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
- "This API is not implemented yet."
- ));
+ // For backwards compatibility, we support fetch commits for the empty
groupId.
+ if (groupId == null) {
+ return
FutureUtils.failedFuture(Errors.INVALID_GROUP_ID.exception());
+ }
+
+ // The require stable flag when set tells the broker to hold on
returning unstable
Review Comment:
The next write operation could actually be ran before the previous one in
completed (or committed) but the write operations guarantees that the second
one is completed only after the first one in order to respect the timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
