dajac commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1311524062


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##########
@@ -183,20 +183,21 @@ public 
List<OffsetFetchResponseData.OffsetFetchResponseTopics> fetchOffsets(
             long committedOffset
         ) {
             return offsetMetadataManager.fetchOffsets(
-                groupId,
-                topics,
+                new OffsetFetchRequestData.OffsetFetchRequestGroup()
+                    .setGroupId(groupId)
+                    .setTopics(topics),
                 committedOffset
-            );
+            ).topics();

Review Comment:
   It found it easier to use in tests like this. Note that I updated the code 
to verify that the group id in the response is set correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to