dajac commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1311525523
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##########
@@ -170,29 +170,27 @@
CompletableFuture<DeleteGroupsResponseData.DeletableGroupResultCollection> delet
* Fetch offsets for a given Group.
*
* @param context The request context.
- * @param groupId The group id.
- * @param topics The topics to fetch the offsets for.
+ * @param request The OffsetFetchRequestGroup request.
*
* @return A future yielding the results or an exception.
*/
- CompletableFuture<List<OffsetFetchResponseData.OffsetFetchResponseTopics>>
fetchOffsets(
+ CompletableFuture<OffsetFetchResponseData.OffsetFetchResponseGroup>
fetchOffsets(
RequestContext context,
- String groupId,
- List<OffsetFetchRequestData.OffsetFetchRequestTopics> topics,
+ OffsetFetchRequestData.OffsetFetchRequestGroup request,
boolean requireStable
);
/**
* Fetch all offsets for a given Group.
*
* @param context The request context.
- * @param groupId The group id.
+ * @param request The OffsetFetchRequestGroup request.
*
* @return A future yielding the results or an exception.
*/
- CompletableFuture<List<OffsetFetchResponseData.OffsetFetchResponseTopics>>
fetchAllOffsets(
+ CompletableFuture<OffsetFetchResponseData.OffsetFetchResponseGroup>
fetchAllOffsets(
Review Comment:
That's a good question. I personally find it a little clearer as it is but I
don't feel very strong about it. @jolshan What do you think? Anyway, I would
consider doing this separately as it requires more changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
