hudeqi commented on code in PR #14077:
URL: https://github.com/apache/kafka/pull/14077#discussion_r1314592488
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceMetrics.java:
##########
@@ -104,12 +108,25 @@ class MirrorSourceMetrics implements AutoCloseable {
replicationLatencyAvg = new MetricNameTemplate(
"replication-latency-ms-avg", SOURCE_CONNECTOR_GROUP,
"Average time it takes records to replicate from source to
target cluster.", partitionTags);
+ replicationOffsetLag = new MetricNameTemplate(
Review Comment:
I guess we have a disagreement about lag? My understanding of lag is: the
real LEO of the source cluster partition minus the LEO that has been written to
the target cluster. It seems that your definition of lag is: the lag between
the mirror task getting data from consumption and writing it to the target
cluster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
