kirktrue commented on code in PR #14359:
URL: https://github.com/apache/kafka/pull/14359#discussion_r1325061757
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -256,138 +258,23 @@ protected FetchRequest.Builder createFetchRequest(final
Node fetchTarget,
}
/**
- * Return the fetched records, empty the record buffer and update the
consumed position.
- *
- * </p>
+ * Return the list of <em>fetchable</em> partitions, which are the set of
partitions to which we are subscribed,
+ * but <em>excluding</em> any partitions for which we still have buffered
data. The idea is that since the user
+ * has yet to process the data for the partition that has already been
fetch, we should not go send for more data
Review Comment:
Fixed. Also made this method return a `Set` which is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
