[GitHub] [kafka] kirktrue commented on a diff in pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

[via GitHub]

kirktrue commented on code in PR #14359:
URL: https://github.com/apache/kafka/pull/14359#discussion_r1326504874


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CompletedFetchTest.java:
##########
@@ -115,13 +122,17 @@ public void testCommittedTransactionRecordsIncluded() {
         Records rawRecords = 
newTranscactionalRecords(ControlRecordType.COMMIT, numRecords);
         FetchResponseData.PartitionData partitionData = new 
FetchResponseData.PartitionData()
                 .setRecords(rawRecords);
-        CompletedFetch<String, String> completedFetch = 
newCompletedFetch(IsolationLevel.READ_COMMITTED,
-                OffsetResetStrategy.NONE,
-                true,
-                0,
+        CompletedFetch completedFetch = newCompletedFetch(0,

Review Comment:
   Done. I double-checked that I caught the places where the method args were 
unnecessarily broken over two lines, but let me know if I missed any. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org